[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only versio
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open |
Date: |
Tue, 22 Jul 2014 13:26:00 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Tue, 22 Jul 2014, Roger Pau Monné wrote:
> On 27/05/14 15:29, Stefan Hajnoczi wrote:
> > On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote:
> >> The current behaviour of tap_open for BSD systems differ greatly from
> >> it's Linux counterpart. Since FreeBSD supports interface renaming and
> >> tap device cloning by opening /dev/tap, implement a FreeBSD specific
> >> version of tap_open that behaves like it's Linux counterpart.
> >>
> >> This is specially important for toolstacks that use Qemu (like Xen
> >> libxl), in order to have a unified behaviour across suported
> >> platforms.
> >>
> >> Signed-off-by: Roger Pau Monné <address@hidden>
> >> Cc: address@hidden
> >> Cc: Stefano Stabellini <address@hidden>
> >> Cc: Anthony Liguori <address@hidden>
> >> Cc: Stefan Hajnoczi <address@hidden>
> >> ---
> >> net/tap-bsd.c | 70
> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >> 1 files changed, 69 insertions(+), 1 deletions(-)
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
>
> I still don't see this committed to the repository, should I ping someone?
I was assuming that this patch would go via some other tree. But if
Stefan is OK I could pick it up and submit a pull request for both patch
1 and 2 of this series.