[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 47/49] replay: replay_break command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 47/49] replay: replay_break command |
Date: |
Fri, 18 Jul 2014 09:58:15 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/17/2014 05:06 AM, Pavel Dovgalyuk wrote:
> This patch adds support for replay_break monitor command. This command
> sets the step (measured in executed instructions) where replay should be
> stopped.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
> hmp-commands.hx | 14 ++++++++++++++
> monitor.c | 15 +++++++++++++++
> qapi-schema.json | 11 +++++++++++
> qmp-commands.hx | 23 +++++++++++++++++++++++
> replay/replay-qmp.c | 13 +++++++++++++
> replay/replay.c | 24 +++++++++++++++++++++++-
> replay/replay.h | 2 ++
> 7 files changed, 101 insertions(+), 1 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -3518,3 +3518,14 @@
> # Since: 2.2
> ##
> { 'command': 'replay_info', 'returns': 'ReplayInfo' }
> +
> +##
> +# @replay_break
replay-break in QMP
> +#
> +# Sets breakpoint at the specified step of replaying
> +#
> +# @step: step where breakpoint should be set
> +#
> +# Since: 2.2
Is the double space intentional?
This is a very high-level description - reading just this definition, I
don't know what typical settings are, and whether changing the number to
be larger or smaller makes a difference. Might be worth a bit more docs.
I hate write-only interfaces - how do I query what the current
breakpoint step is?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate, (continued)
- [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 09/49] pckbd: adding new fields to vmstate, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 42/49] replay: network packets record/replay, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 44/49] replay: serial port, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 43/49] replay: audio data record/replay, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 45/49] replay: USB passthrough, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 46/49] replay: replay_info command, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 47/49] replay: replay_break command, Pavel Dovgalyuk, 2014/07/17
- Re: [Qemu-devel] [RFC PATCH v2 47/49] replay: replay_break command,
Eric Blake <=
- [Qemu-devel] [RFC PATCH v2 49/49] gdbstub: reverse debugging, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 48/49] replay: replay_seek_step command, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 25/49] target-i386: instructions counting code for replay, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 17/49] target-i386: update fp status fix, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 27/49] vga: do not use virtual clock for blinking cursor, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 15/49] softmmu: fixing usage of cpu_st/ld* from helpers, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 32/49] replay: checkpoints, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 26/49] replay: interrupts and exceptions, Pavel Dovgalyuk, 2014/07/17
- [Qemu-devel] [RFC PATCH v2 19/49] replay: global variables and function stubs, Pavel Dovgalyuk, 2014/07/17