[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/6] module: Simplify module_load()
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 3/6] module: Simplify module_load() |
Date: |
Fri, 18 Jul 2014 15:31:39 +0200 |
From: Andreas Färber <address@hidden>
The file path is not used for error reporting, so we can free it
directly after use.
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
util/module.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/util/module.c b/util/module.c
index 214effb..9fd3030 100644
--- a/util/module.c
+++ b/util/module.c
@@ -202,18 +202,16 @@ static void module_load(module_init_type type)
for (i = 0; i < ARRAY_SIZE(dirs); i++) {
fname = g_strdup_printf("%s/%s%s", dirs[i], *mp, HOST_DSOSUF);
ret = module_load_file(fname);
+ g_free(fname);
+ fname = NULL;
/* Try loading until loaded a module file */
if (!ret) {
break;
}
- g_free(fname);
- fname = NULL;
}
if (ret == -ENOENT) {
fprintf(stderr, "Can't find module: %s\n", *mp);
}
-
- g_free(fname);
}
for (i = 0; i < ARRAY_SIZE(dirs); i++) {
--
1.9.3
- [Qemu-devel] [PULL v2 for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18, Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled., Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 3/6] module: Simplify module_load(),
Paolo Bonzini <=
- [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent, Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation", Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700, Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward", Paolo Bonzini, 2014/07/18
- Re: [Qemu-devel] [PULL v2 for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18, Peter Maydell, 2014/07/18