[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] raw-posix: Fail gracefully if no working al
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] raw-posix: Fail gracefully if no working alignment is found |
Date: |
Wed, 16 Jul 2014 12:08:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/16/2014 09:48 AM, Kevin Wolf wrote:
> If qemu couldn't find out what O_DIRECT alignment to use with a given
> file, it would run into assert(bdrv_opt_mem_align(bs) != 0); in block.c
> and confuse users. This adds a more descriptive error message for such
> cases.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/raw-posix.c | 35 +++++++++++++++++++++++++++--------
> 1 file changed, 27 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature