[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.1 V2] qemu-img info: show nocow info
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for 2.1 V2] qemu-img info: show nocow info |
Date: |
Tue, 08 Jul 2014 19:08:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/07/2014 09:08 PM, Chunyan Liu wrote:
> Add nocow info in 'qemu-img info' output to show whether the file
> currently has NOCOW flag set or not.
>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
> Changes:
> - add documentation of "nocow" in qapi/block-core.json.
>
> @@ -625,4 +646,8 @@ void bdrv_image_info_dump(fprintf_function func_fprintf,
> void *f,
> func_fprintf(f, "Format specific information:\n");
> bdrv_image_info_specific_dump(func_fprintf, f,
> info->format_specific);
> }
> +
> + if (info->has_nocow && info->nocow) {
> + func_fprintf(f, "Set NOCOW flag: yes\n");
Reads awkwardly. How about:
NOCOW flag: set
(and if we could reliably tell that the fs supports nocow but the flag
is clear, then we could have 'NOCOW flag: clear')
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature