[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/15] target-tricore: Add instructions of SSR o
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 08/15] target-tricore: Add instructions of SSR opcode format |
Date: |
Mon, 07 Jul 2014 13:22:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote:
> + case OPC1_16_SSR_ST_B:
> + r1 = MASK_OP_SSR_S1(ctx->opcode);
> + r2 = MASK_OP_SSR_S2(ctx->opcode);
> + temp = tcg_temp_new();
> + tcg_gen_andi_tl(temp, cpu_gpr_d[r1], 0xff);
> + tcg_gen_qemu_st8(temp, cpu_gpr_a[r2], ctx->mem_idx);
> + tcg_temp_free(temp);
The andi is just silly. Of course the st8 will only examine the low 8 bits.
Likewise for the _H insns.
r~
- [Qemu-devel] [PATCH 04/15] target-tricore: Add initialization for translation, (continued)
- [Qemu-devel] [PATCH 04/15] target-tricore: Add initialization for translation, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 11/15] target-tricore: Add instructions of SBC and SBRN opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 12/15] target-tricore: Add instructions of SBR opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 08/15] target-tricore: Add instructions of SSR opcode format, Bastian Koppelmann, 2014/07/07
- Re: [Qemu-devel] [PATCH 08/15] target-tricore: Add instructions of SSR opcode format,
Richard Henderson <=
- [Qemu-devel] [PATCH 10/15] target-tricore: Add instructions of SB opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 14/15] target-tricore: Add instructions of SLR, SSRO and SRO opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 03/15] target-tricore: Add softmmu support, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 09/15] target-tricore: Add instructions of SRRS and SLRO opcode format., Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 07/15] target-tricore: Add instructions of SRR opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 02/15] target-tricore: Add board for systemmode, Bastian Koppelmann, 2014/07/07