Re: [Qemu-devel] [PATCH] qmp: show QOM properties in device-list-properties

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> Il 06/07/2014 21:03, Cole Robinson ha scritto:
>> On 07/05/2014 05:14 AM, Paolo Bonzini wrote:
>>> Il 20/05/2014 14:29, Stefan Hajnoczi ha scritto:
>>>> Devices can use a mix of qdev and QOM properties.  Currently only the
>>>> qdev properties are displayed by device-list-properties.
>>>>
>>>> This patch extends the property enumeration algorithm to also display
>>>> QOM properties (excluding the implicit "type", "realized",
>>>> "hotpluggable", and "parent_bus" properties).
>>>>
>>>> When a qdev property exists, use the qdev type name to preserve
>>>> backwards compatibility.  QOM type names can be different for bool (qdev
>>>> on/off) and str (used by qdev pointers).
>>>>
>>>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>>
>>>
>>> Stefan, was this never applied?
>>>
>>
>> I assume you CC'd me in reference to the bug I reported:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2014-07/msg00882.html
>>
>> I tested this patch, but it doesn't fix the specific bit I mentioned (lack of
>> 'bootindex' in -device virtio-blk,? )
>
> Yes, it doesn't, but does libvirt work then?  I'm not sure if libvirt
> still uses -device or rather device-list-properties (which lets you
> start a single QEMU process and do multiple probes).

Valid question, but of course we need to fix the -device FOO,help
regression regardless.