[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virt
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling |
Date: |
Wed, 02 Jul 2014 10:25:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 01/07/14 17:25, Stefan Hajnoczi wrote:
> This series fixes issues recently introduced when unifying virtio-blk
> dataplane's request handling with non-dataplane virtio-blk.
>
> The problems include broken memory allocation for dataplane requests and a
> performance regression for non-dataplane. See the patches for details.
>
> Stefan Hajnoczi (4):
> virtio-blk: avoid dataplane VirtIOBlockReq early free
> dataplane: do not free VirtQueueElement in vring_push()
> virtio-blk: avoid g_slice_new0() for VirtIOBlockReq and
> VirtQueueElement
> virtio-blk: embed VirtQueueElement in VirtIOBlockReq
>
> hw/block/dataplane/virtio-blk.c | 30 +++++++++++-----------
> hw/block/virtio-blk.c | 50
> ++++++++++++++++++-------------------
> hw/virtio/dataplane/vring.c | 22 ++++++----------
> include/hw/virtio/dataplane/vring.h | 3 +--
> include/hw/virtio/virtio-blk.h | 6 ++++-
> 5 files changed, 53 insertions(+), 58 deletions(-)
>
I need patches 1 and 2 to make dataplane work.
For both patches
Tested-by: Christian Borntraeger <address@hidden>
Would be good to see both patches in master soon. (no opinion about 3 and 4).
Christian
- [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PATCH v2 1/4] virtio-blk: avoid dataplane VirtIOBlockReq early free, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PATCH v2 2/4] dataplane: do not free VirtQueueElement in vring_push(), Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PATCH v2 3/4] virtio-blk: avoid g_slice_new0() for VirtIOBlockReq and VirtQueueElement, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PATCH v2 4/4] virtio-blk: embed VirtQueueElement in VirtIOBlockReq, Stefan Hajnoczi, 2014/07/01
- Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling, Stefan Hajnoczi, 2014/07/08