[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space() |
Date: |
Wed, 2 Jul 2014 09:29:54 +0300 |
On Wed, Jul 02, 2014 at 08:06:35AM +0800, Le Tan wrote:
> In function do_pci_register_device() in file hw/pci/pci.c, move the assignment
> of pci_dev->devfn to the position before the call to
> pci_device_iommu_address_space(pci_dev) which will use the value of
> pci_dev->devfn.
Thanks, applied
Fixes: 9eda7d373e9c691c070eddcbe3467b991f67f6bd
pci: Introduce helper to retrieve a PCI device's DMA address space
Cc: address@hidden
> Signed-off-by: Le Tan <address@hidden>
> ---
> hw/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 17ed510..351d320 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -827,6 +827,7 @@ static PCIDevice *do_pci_register_device(PCIDevice
> *pci_dev, PCIBus *bus,
> }
>
> pci_dev->bus = bus;
> + pci_dev->devfn = devfn;
> dma_as = pci_device_iommu_address_space(pci_dev);
>
> memory_region_init_alias(&pci_dev->bus_master_enable_region,
> @@ -836,7 +837,6 @@ static PCIDevice *do_pci_register_device(PCIDevice
> *pci_dev, PCIBus *bus,
> address_space_init(&pci_dev->bus_master_as,
> &pci_dev->bus_master_enable_region,
> name);
>
> - pci_dev->devfn = devfn;
> pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
> pci_dev->irq_state = 0;
> pci_config_alloc(pci_dev);
> --
> 1.7.9.5