Re: [Qemu-devel] [PATCH 1/4] switch RAM_ADDR_FMT format specifier to print decimal

[Peter Maydell]

On 25 June 2014 12:42, Igor Mammedov <address@hidden> wrote
> ... and add RAM_ADDR_FMTX for hex format. In addition fix
> places to print sizes/lengths as decimal and addresses as hex.

Please can you make the 'body' part of your commit messages
stand on its own? It's kind of hard to understand when half of the
sentence is off wherever the mail client displays its Subject line
and only half is in the email body.

> Also drop "%" from RAM_ADDR_FMT macro and use it like other
> PRIfoo format placeholders specifying "%" explicitly.

[If you find yourself writing "And... Also..." in a commit message
it's often a sign that you probably want to split it into more than
one patch.]

If you're going to do this you should just create a set of
RAMADDR_PRI[diouxX] like we have for HWADDR, rather
than leaving the non-standard RAM_ADDR_FMT name.

Please don't change the default meaning of RAM_ADDR_FMT
in the same commit as making a lot of boilerplate no-effect
changes to move % characters around; if there are cases that
would be better done as decimal then those behavioural
changes should be done in their own patches so it's clear
which things have been changed.

thanks
-- PMM