[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] mc146818rtc: add rtc-reset-reinjection QMP c
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] mc146818rtc: add rtc-reset-reinjection QMP command |
|
Date: |
Wed, 25 Jun 2014 07:58:14 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/25/2014 05:40 AM, Michael S. Tsirkin wrote:
> It is necessary to reset RTC interrupt reinjection backlog if
> guest time is synchronized via a different mechanism, such as
> QGA's guest-set-time command.
>
> Failing to do so causes both corrections to be applied (summed),
> resulting in an incorrect guest time.
>
> Signed-off-by: Marcelo Tosatti <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>
> Marcelo, is this right?
>
> Changes from v3:
> rebase on top of master
> fixes error code
> drop dead code
>
> qapi-schema.json | 12 ++++++++++++
> hw/timer/mc146818rtc.c | 18 ++++++++++++++++++
> monitor.c | 7 +++++++
> qmp-commands.hx | 23 +++++++++++++++++++++++
> 4 files changed, 60 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature