Re: [Qemu-devel] [PATCH v3] qmp: add ACPI_DEVICE_OST event handling

[Eric Blake]

On 06/23/2014 09:59 AM, Eric Blake wrote:
> On 06/21/2014 11:58 PM, Michael S. Tsirkin wrote:
>> On Fri, Jun 20, 2014 at 10:33:26AM +0200, Igor Mammedov wrote:
>>> emits event when ACPI OSPM evaluates _OST method
>>> of ACPI device.
>>>
>>> Signed-off-by: Igor Mammedov <address@hidden>
>>
>> The subject and commit log are confusing here.
>> We already have
>>      Author: Igor Mammedov <address@hidden>
>>          qmp: add ACPI_DEVICE_OST event handling
>>
>> So I am guessing this reworks existing functionality
>> to use the new QMP infrastructure.
>> Please rewrite both subject and commit log.
>>
> 
> Based on IRC chatter, it looks like Igor has reworked the patch to be
> applied as part of Luiz' QMP queue in a way that minimizes the conflicts
> there.  Igor's rework is more-or-less a revert of the v2 patch that was
> applied prematurely in mst's tree, combined with this v3 patch to apply
> correctly in Wenchao's event-as-qapi series on Luiz' tree.
> 
> At this point, I'd wait for a PULL request from Luiz to determine if
> anything further is needed on this front.

Indeed,
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg05424.html (in
particular 33/43) solves the problems.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature