[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-m
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror |
Date: |
Thu, 19 Jun 2014 17:19:35 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 16, 2014 at 12:00:56PM +0200, Benoît Canet wrote:
> +BlockDriverState *check_to_replace_node(const char *node_name, Error **errp)
> +{
> + BlockDriverState *to_replace_bs = bdrv_find_node(node_name);
> + if (!to_replace_bs) {
> + error_setg(errp, "Node name '%s' not found",
> + node_name);
> + return NULL;
> + }
> +
> + if (bdrv_op_is_blocked(to_replace_bs, BLOCK_OP_TYPE_REPLACE, errp)) {
> + return NULL;
> + }
Currently bdrv_op_is_blocked(to_replace_bs, BLOCK_OP_TYPE_REPLACE, errp)
is not effective since child nodes never have op blockers. Only the
root node/drive has op blockers.
We discussed propagating blockers to child nodes. Can you send a patch
to address this? I think Jeff will need to rebase his node-name series
too.
Stefan
pgpi_mTTtkqoL.pgp
Description: PGP signature
[Qemu-devel] [PATCH v10 1/4] quorum: Add the rewrite-corrupted parameter to quorum, Benoît Canet, 2014/06/16
Re: [Qemu-devel] [PATCH v10 0/4] Quorum maintainance operations, Stefan Hajnoczi, 2014/06/19
Re: [Qemu-devel] [PATCH v10 0/4] Quorum maintainance operations, Kevin Wolf, 2014/06/27