Re: [Qemu-devel] [PATCH qom v2 2/4] hw: Fix qemu_allocate_irqs() leaks

[Kirill Batuzov]

On Wed, 18 Jun 2014, Peter Crosthwaite wrote:

> From: Andreas Färber <address@hidden>
> 
> Replace qemu_allocate_irqs(foo, bar, 1)[0]
> with qemu_allocate_irq(foo, bar, 0).
> 
> This avoids leaking the dereferenced qemu_irq *.
> 
> Cc: Kirill Batuzov <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Reviewed-by: Peter Crosthwaite <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> [PC Changes:
>  * Applied change to instance in sh4/sh7750.c
> ]
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> Changed since 1:
> Applied change to instance in sh4/sh7750.c (Kirill review)
> 
>  hw/arm/omap1.c          | 14 +++++++-------
>  hw/arm/omap2.c          |  2 +-
>  hw/arm/pxa2xx.c         |  4 ++--
>  hw/arm/spitz.c          |  4 ++--
>  hw/arm/z2.c             |  2 +-
>  hw/core/irq.c           |  4 ++--
>  hw/dma/omap_dma.c       |  4 ++--
>  hw/ide/microdrive.c     |  2 +-
>  hw/misc/cbus.c          |  6 +++---
>  hw/pcmcia/pxa2xx.c      |  2 +-
>  hw/sd/omap_mmc.c        |  2 +-
>  hw/sd/sdhci.c           |  4 ++--
>  hw/sh4/sh7750.c         |  3 +--
>  hw/timer/omap_gptimer.c |  4 ++--
>  14 files changed, 28 insertions(+), 29 deletions(-)
>

Reviewed-by: Kirill Batuzov <address@hidden>

-- 
Kirill