qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/block/pflash_cfi01: Report correct size info


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] hw/block/pflash_cfi01: Report correct size info for parallel configs
Date: Wed, 18 Jun 2014 18:52:13 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Jun 16, 2014 at 11:52:22AM +0100, Peter Maydell wrote:
> On 10 June 2014 15:03, Peter Maydell <address@hidden> wrote:
> > If the flash device is configured with a device-width which is
> > not equal to the bank-width, indicating that it is actually several
> > narrow flash devices in parallel, the CFI table should report the
> > number of blocks and the size of a single device, not of the whole
> > combined setup. This stops Linux from complaining:
> > "NOR chip too large to fit in mapping. Attempting to cope..."
> >
> > As usual, we retain the old broken but backwards compatible behaviour
> > when the device-width is not specified.
> >
> > Signed-off-by: Peter Maydell <address@hidden>
> > ---
> > At the moment vexpress is the only board which properly sets device-width
> > rather than using the back-compat misemulated behaviour...
> 
> Kevin, Stefan: since this only affects ARM boards at
> the moment, I'll put this in via target-arm.next unless
> you particularly want to put it in through the block queue.

That's fine.

Stefan

Attachment: pgpeEYHJhdOwh.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]