Re: [Qemu-devel] [PATCH 5/5] mc146818rtc: add "rtc" link to "/machine"

[Andreas Färber]

Am 17.06.2014 17:01, schrieb Paolo Bonzini:
> Il 17/06/2014 16:25, Peter Crosthwaite ha scritto:
>>> > &error_warn? :)  But then, /machine/rtc.tm is the only supported
>>> interface,
>> I have thought about &error_warn in the past, but thought the better
>> of it. Warnings need user digestable message and I can't think of a
>> sane implementation where you populate a message for error framework
>> to raise while maintaining the needed errp == NULL || *errp == NULL
>> semantic at the same time.
>>
>>> > and it should be the same for all RTC devices so perhaps a NULL error
>>> > pointer is enough.
>>> >
>> NULL Works for me. But other than source verbosity is there any reason
>> to not catch the error?:
> 
> See above: it doesn't matter _which_ RTC gets the magic alias.  For a
> proper implementation, they should all be the same.

Doesn't this "alias" potentially change the canonical path since the new
property's type is going to be child<foo>?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg