Re: [Qemu-devel] checkpatch.pl question

[Peter Maydell]

On 6 June 2014 08:17, Markus Armbruster <address@hidden> wrote:
> --debug values=1 produces
>
> 188 > . extern int vfio_container_ioctl(AddressSpace *as, int32_t groupid,
> 188 > EEVVVVVVVTTTTVVVVVVVVVVVVVVVVVVVVNTTTTTTTTTTTTTTVVCCTTTTTTTTVVVVVVVCC
>
> which suggests it recognizes the declaration just fine.
>
> Copying a few possible victims^Wexperts.

It's clearly something to do with it getting confused by the type name,
because you can suppress the warning by just changing it so it has
an "_t" suffix, for instance. In particular notice that the set of allowed
type names constructed by the build_types() subroutine is extremely
limited: it looks to me as if the script makes assumptions based on
kernel style (where 'struct foo' is preferred over a typedef and plain
'foo') that allow it to assume that if it's not one of a very few allowed
formats then it's not a type name.

I find this script extremely hard to understand, though.

thanks
-- PMM