Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

[Dave Mielke]

[quoted lines by Gerd Hoffmann on 2014/05/28 at 14:26 +0200]

Hi:

>Little series of three input patches.  First patch adds support for
>submitting keyboard delays, which will make the input layer setup a
>timer, buffer the following keyboard events, send them to the guest
>once the delay is over.  Second patch makes the send_key monitor command
>use the new service instead of using its own timer.  Third patch inserts
>a delay between keydown and keyup events in the curses ui.
>
>please review & test,

This approach doesn't work, although the problem is different. Input is now 
recognized, but unwanted key repeats creep in. For example, I typed "exit" and 
got "exiitt". I tested this several times while typing as accurately and 
quickly as I could.

My theory is that the key releases aren't being detected by the application 
until the next key press/release delay, thus effectively leaving the keys 
pressed.

I've attached the latest verson of my patch (qemu-kbddelay-2.patch) to this 
message in case you're interested in considering it. It merges the delay option 
into the -k option, so we'd have this:

   -k [[language=]language][,delay=msecs]

-- 
Dave Mielke           | 2213 Fox Crescent | The Bible is the very Word of God.
Phone: 1-613-726-0014 | Ottawa, Ontario   | http://Mielke.cc/bible/
EMail: address@hidden | Canada  K2A 1H7   | http://FamilyRadio.com/

qemu-kbddelay-2.patch
Description: Text document