Re: [Qemu-devel] [PATCH v4 10/10] trace: [tcg] Include TCG-tracing header on all targets

[Lluís Vilanova]

Richard Henderson writes:

> On 05/29/2014 05:23 AM, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> target-alpha/translate.c      |    3 +++
>> target-arm/translate-a64.c    |    2 ++
>> target-arm/translate.c        |    3 +++
>> target-cris/translate.c       |    3 +++
>> target-i386/translate.c       |    3 +++
>> target-lm32/translate.c       |    3 +++
>> target-m68k/translate.c       |    3 +++
>> target-microblaze/translate.c |    3 +++
>> target-mips/translate.c       |    3 +++
>> target-openrisc/translate.c   |    3 +++
>> target-ppc/translate.c        |    3 +++
>> target-s390x/translate.c      |    2 ++
>> target-sh4/translate.c        |    3 +++
>> target-sparc/translate.c      |    3 +++
>> target-unicore32/translate.c  |    3 +++
>> target-xtensa/translate.c     |    3 +++
>> 16 files changed, 46 insertions(+)
>> 
>> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
>> index e31d56c..9e2a773 100644
>> --- a/target-alpha/translate.c
>> +++ b/target-alpha/translate.c
>> @@ -25,6 +25,9 @@
>> #include "exec/helper-proto.h"
>> #include "exec/helper-gen.h"
>> 
>> +#include "trace-tcg.h"

> Continued from 7 ... Or indeed 3 different includes into exec/helper-gen.h?

> Or perhaps I'm a bit confused as to what difference there is between
> trace-tcg.h and the %(name)s(%(args)s) helpers you're generating?

This "trace-tcg.h" provides a convenience function for every event. It basically
calls "trace_event_trans" (which produces a trace entry for event "event_trans",
defined in "trace.h"), and also calls "gen_helper_trace_event_exec" (which
produces the TCG code to call "trace_event_exec" at guest execution time,
defined in "trace/generated-helpers.h").

This file (or the same with a different name) could be included from some of the
"helper-*" headers, but since it provides the tracing user interface, I thought
it would be better to include it explicitly (like "trace.h").


Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth