Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

[Peter Crosthwaite]

On Fri, May 30, 2014 at 1:25 AM, Paolo Bonzini <address@hidden> wrote:
> Il 29/05/2014 16:05, Peter Crosthwaite ha scritto:
>
>>> > +    path = object_get_canonical_path_component(OBJECT(backend));
>>> > +    memory_region_init_ram(&backend->mr, OBJECT(backend), path,
>>
>> Passing the full canonical path as the name of memory region is
>> redundant as that information is already passed via the owner
>> argument. It should just be a shorthand.
>>
>
> It's not the full canonical path, it's basically the id.
>

Fair enough. Although its still redundant though isn't it?

Should we ever clean up messages etc in memory api to include both
owner and name this is going to come out:

"foo/bar/baz:baz"

or some such.

Then again, if we are only worried about getting a sane shorthand,
perhaps what Igor has done here is a sane default for the memory API
when passed a NULL name?

Regards,
Peter

> Paolo
>