Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

[Petar Jovanovic]

> change as CP0_Config3 is a read-only register. If I am right, probably
> the best is to check directly env->CP0_Config3.

If you take a look at v1 of the patch, that's what was done.
In the code review, this was marked as unacceptable because it
required [1] passing env within the translator.


[1] http://patchwork.ozlabs.org/patch/349709/
________________________________________
From: Aurelien Jarno address@hidden
Sent: Thursday, May 29, 2014 3:08 PM
To: Petar Jovanovic
Cc: Petar Jovanovic; address@hidden; address@hidden; address@hidden
Subject: Re: [v3 PATCH] target-mips: implement UserLocal Register

On Thu, May 29, 2014 at 01:01:38PM +0000, Petar Jovanovic wrote:
> > While adding MIPS_HFLAG_HWRENA_ULR is a good idea for performance
> > reasons, I don't think we should add MIPS_HFLAG_CP0UL. This value is
> > always the same (true or false) during all the run time of the
> > qemu-system-mips binary, and thus we don't need to take care of code
> > generated with it being true or being false.
>
> Initial version of this patch did not have this flag, but it was added
> as requested in code review.
> What do you suggest?

Well maybe I missed something, but it looks to me the value can never
change as CP0_Config3 is a read-only register. If I am right, probably
the best is to check directly env->CP0_Config3.

--
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net