Re: [Qemu-devel] [PATCH 1/1] bsd-user: add HOST_VARIANT_DIR for various *BSD dependent code

[Peter Maydell]

On 28 May 2014 12:53, Sean Bruno <address@hidden> wrote:
> From: Stacey Son <address@hidden>
>
> This change adds HOST_VARIANT_DIR so the various BSD OS dependent
> code can be seperated into its own directories rather than
> using #ifdef's.   This may also allow an BSD variant OS to host
> another BSD variant's executible as a target.

You're missing signed-off-by: lines here.

What you need is
(a) Stacey's Signed-off-by: line, since he's the author of the patch
(b) your own Signed-off-by:, since you're the one posting it to the
list to be included.

Also, I think this patch should be in a series with the code which
makes use of the new define. Otherwise committing this would
just leave us with a #define which we set but never use. (The patch
itself looks OK to me, though.)

thanks
-- PMM