qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] block: Drop superfluous aligning of bdrv_ge


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 4/5] block: Drop superfluous aligning of bdrv_getlength()'s value
Date: Wed, 28 May 2014 13:08:06 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Am 09.05.2014 um 11:48 hat Markus Armbruster geschrieben:
>> It returns a multiple of the sector size.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Sooner or later this will change. If we do want to remove the rounding,
> how about adding an assertion instead so that we find those places at
> least when bdrv_getlength() is changed to byte granularity?

There are quite a few places that silently assume bdrv_getlength()'s
value is a multiple of BDRV_SECTOR_SIZE, or even of 512.  Regardless,
I'm happy to add assertions here.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]