Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_di

From:	Markus Armbruster
Subject:	Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency()
Date:	Wed, 28 May 2014 11:27:53 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Am 26.05.2014 um 19:37 hat Markus Armbruster geschrieben:
>> On error path.  Introduced in commit a046433a.  Spotted by Coverity.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Heh, that fail: label you're jumping to is well hidden in some random
> error check in the middle of the function. Pure awesomeness, this code.
>
> (Your fix looks correct, but I just had to comment on this...)

I expect nothing less than pure awesomeness from vvfat!

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [Qemu-devel] [PATCH 02/14] block/vvfat: Plug memory leak in enable_write_target(), (continued)
- [Qemu-devel] [PATCH 04/14] block: Plug memory leak on brv_open_image() error path, Markus Armbruster, 2014/05/26
  - Re: [Qemu-devel] [PATCH 04/14] block: Plug memory leak on brv_open_image() error path, Benoît Canet, 2014/05/27
- [Qemu-devel] [PATCH 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths, Markus Armbruster, 2014/05/26
  - Re: [Qemu-devel] [PATCH 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths, Benoît Canet, 2014/05/27
- [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster, 2014/05/26
  - Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Benoît Canet, 2014/05/27
    - Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster, 2014/05/27
  - Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Kevin Wolf, 2014/05/28
    - Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster <=
- [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, Markus Armbruster, 2014/05/26
  - Re: [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, Benoît Canet, 2014/05/27
    - Re: [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, Markus Armbruster, 2014/05/27
- [Qemu-devel] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Markus Armbruster, 2014/05/26
  - Re: [Qemu-devel] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Benoît Canet, 2014/05/27
- [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/26
  - Re: [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Benoît Canet, 2014/05/27
  - Re: [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Eric Blake, 2014/05/27
    - Re: [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/27
- [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command, Markus Armbruster, 2014/05/26

Prev by Date: Re: [Qemu-devel] [RFC PATCH 2/4] icount: Make icount_time_shift available everywhere
Next by Date: Re: [Qemu-devel] [PULL 00/33] Block patches
Previous by thread: Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency()
Next by thread: [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command
Index(es):
- Date
- Thread