[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] configure: robustify big/little check
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] configure: robustify big/little check |
|
Date: |
Wed, 28 May 2014 11:16:09 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On 28 May 2014 09:46, Cornelia Huck <address@hidden> wrote:
>> The check for big or little endianness relies on grep reporting
>> match/non-match on the generated binary. If the user specified
>> --binary-files=without-match in their GREP_OPTIONS, this will fail.
>> Let's just explicitly specify --binary-files=binary, which will
>> override any user settings and do what we want.
>
> This grep option isn't specified by POSIX so I'm not sure all the hosts
> we build on will have it. Maybe it would be better to just unset
> GREP_OPTIONS at the top of configure ?
That's what autoconf does:
# Unset more variables known to interfere with behavior of common tools.
CLICOLOR_FORCE= GREP_OPTIONS=
unset CLICOLOR_FORCE GREP_OPTIONS