Re: [Qemu-devel] [PATCH v7 3/3] sPAPR: EEH support for VFIO PCI device

[Benjamin Herrenschmidt]

On Wed, 2014-05-28 at 00:22 +0200, Alexander Graf wrote:
> > +void spapr_eeh_rtas_init(sPAPREnvironment *spapr)
> > +{
> > +    spapr_rtas_register("ibm,set-eeh-option",
> > +                        rtas_ibm_set_eeh_option);
> > +    spapr_rtas_register("ibm,get-config-addr-info2",
> > +                        rtas_ibm_get_config_addr_info2);
> > +    spapr_rtas_register("ibm,read-slot-reset-state2",
> > +                        rtas_ibm_read_slot_reset_state2);
> > +    spapr_rtas_register("ibm,set-slot-reset",
> > +                        rtas_ibm_set_slot_reset);
> > +    spapr_rtas_register("ibm,configure-pe",
> > +                        rtas_ibm_configure_pe);
> > +    spapr_rtas_register("ibm,slot-error-detail",
> > +                        rtas_ibm_slot_error_detail);
> 
> This goes straight from RTAS to VFIO code. NAK.

It would be much appreciated if instead of "NAK" you actually provided
at least a sentence explaining how you think this should go...

In any case, the above isn't the problem, we register rtas functions
called rtas_ibm_*, that's fine.

The problem you have is with what's inside these functions, correct ?
You want some kind of PCI Dev ops... am I understanding properly ?
Instead of having them call the VFIO ioctl's directly.

Cheers,
Ben.