[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json fi
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis |
Date: |
Tue, 27 May 2014 16:51:58 +0530 |
On (Wed) 21 May 2014 [13:47:44], Markus Armbruster wrote:
> Amit Shah <address@hidden> writes:
>
> > On (Wed) 21 May 2014 [11:03:04], Dr. David Alan Gilbert wrote:
> >> * Amit Shah (address@hidden) wrote:
> >
> >> > The idea is to be able to take a qemu binary and compare with another
> >> > binary; if only fields that are instantiated are used, various
> >> > invocations will have to be tried to find devices that may have
> >> > broken.
> >> >
> >> > An alternative way of checking only devices which have been added to
> >> > the running machine can be done via a monitor command (or a parameter
> >> > to the existing cmdline option). But I'm not sure if that'll be more
> >> > useful than the current one.
> >>
> >> Or perhaps a way to dump that info and mask your checker with it if wanted?
> >
> > A 'blacklist' file, which stores names of sections that you're not
> > interested in?
>
> An error message format that lets me grep -v for sections I'm not
> interested in? Stupidest solution that could possibly work...
The discusison had overfown onto IRC, and I think what David was
looking for was to weed out certain sections altogether, like 'fdc',
if the machines he's interested in do not have floppy drives at all.
The error message format is quite consistent in that regard, I feel,
but opinions on improving it are welcome. Currently, errors/warnings
are reported like this:
Section "usb-kbd" Description "usb-kbd" Field "kbd.keycodes" size mismatch: 4 ,
2
Section "PIIX3-xen" Description "PIIX3": minimum version error: 1 < 2
Section "PIIX3-xen" Description "PIIX3": Entry "Subsections" missing
... and so on.
Amit
[Qemu-devel] [PATCH 02/18] vmstate-static-checker: script to validate vmstate changes, Amit Shah, 2014/05/12
[Qemu-devel] [PATCH 03/18] tests: vmstate static checker: add dump1 and dump2 files, Amit Shah, 2014/05/12
[Qemu-devel] [PATCH 04/18] tests: vmstate static checker: incompat machine types, Amit Shah, 2014/05/12
[Qemu-devel] [PATCH 05/18] tests: vmstate static checker: add version error in main section, Amit Shah, 2014/05/12
[Qemu-devel] [PATCH 06/18] tests: vmstate static checker: version mismatch inside a Description, Amit Shah, 2014/05/12
[Qemu-devel] [PATCH 07/18] tests: vmstate static checker: minimum_version_id check, Amit Shah, 2014/05/12
[Qemu-devel] [PATCH 08/18] tests: vmstate static checker: remove a section, Amit Shah, 2014/05/12
[Qemu-devel] [PATCH 09/18] tests: vmstate static checker: remove a field, Amit Shah, 2014/05/12
[Qemu-devel] [PATCH 10/18] tests: vmstate static checker: remove last field in a struct, Amit Shah, 2014/05/12