Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency()

[Benoît Canet]

The Monday 26 May 2014 à 19:37:12 (+0200), Markus Armbruster wrote :
> On error path.  Introduced in commit a046433a.  Spotted by Coverity.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block/vvfat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 6a0d246..2c82a5c 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1864,7 +1864,7 @@ static int check_directory_consistency(BDRVVVFATState 
> *s,
>  
>       if (s->used_clusters[cluster_num] & USED_ANY) {
>           fprintf(stderr, "cluster %d used more than once\n", 
> (int)cluster_num);
> -         return 0;
> +            goto fail;

Hmm your editor display tabs at 8 chars so you put 12 chars of alignement.
Anyway the patch seems correct.

Reviewed-by: Benoit Canet <address@hidden>

>       }
>       s->used_clusters[cluster_num] = USED_DIRECTORY;
>  
> -- 
> 1.9.3
> 
>