[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobj
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR |
Date: |
Tue, 27 May 2014 12:52:41 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Monday 26 May 2014 à 19:37:11 (+0200), Markus Armbruster wrote :
> Introduced in commit a8d8ecb. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/qapi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index 75f44f1..97e1641 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -475,6 +475,7 @@ static void dump_qobject(fprintf_function func_fprintf,
> void *f,
> case QTYPE_QERROR: {
> QString *value = qerror_human((QError *)obj);
> func_fprintf(f, "%s", qstring_get_str(value));
> + QDECREF(value);
> break;
> }
> case QTYPE_NONE:
> --
> 1.9.3
>
>
Reviewed-by: Benoit Canet <address@hidden>
- Re: [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, (continued)
- [Qemu-devel] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR, Markus Armbruster, 2014/05/26
- Re: [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR,
Benoît Canet <=
- [Qemu-devel] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Markus Armbruster, 2014/05/26
- Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Kevin Wolf, 2014/05/28
- [Qemu-devel] [PATCH 05/14] qemu-io: Support multiple -o in open command, Markus Armbruster, 2014/05/26