[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH net v1 0/4] Cadence GEM patches
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH net v1 0/4] Cadence GEM patches |
Date: |
Sat, 24 May 2014 11:17:52 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 |
24.05.2014 03:06, Peter Crosthwaite wrote:
> Ping^2!
>
> I'll try trivial queue too :)
Actually this looks like trivial material.
I'll comment in one place, for all.
>>> Peter Crosthwaite (4):
>>> net: cadence_gem: Fix Tx descriptor update
This appears to be a bugfix, but with an interesting "incomplete"
update:
...
+ unsigned desc_first[2];
...
cpu_physical_memory_read(s->tx_desc_addr,
- (uint8_t *)&desc[0], sizeof(desc));
+ (uint8_t *)&desc_first[0], sizeof(desc));
sizeof(desc_first), not sizeof(desc). Also can drop extra
"readdressing".
>>> net: cadence_gem: Add Tx descriptor fetch printf
+ DB_PRINT("read descriptor 0x%x\n", (unsigned)packet_desc_addr);
packet_desc_addr is hwaddr, which is uint64_t, here it is being cast
to unsigned, Is it right? Other code in this file does the same,
but it still does not mean it's right. Maybe it is because it uses
only the lower 32 bits of it, or that the high bits just aren't
useful for debugging?
>>> net: cadence_gem: Fix top comment
I applied this one.
>>> net: cadence_gem: Comment spelling sweep
This look okay, except that it clashes a bit with the first.
/mjt
- [Qemu-devel] [PATCH net v1 0/4] Cadence GEM patches, Peter Crosthwaite, 2014/05/07
- [Qemu-devel] [PATCH net v1 1/4] net: cadence_gem: Fix Tx descriptor update, Peter Crosthwaite, 2014/05/07
- [Qemu-devel] [PATCH net v1 2/4] net: cadence_gem: Add Tx descriptor fetch printf, Peter Crosthwaite, 2014/05/07
- [Qemu-devel] [PATCH net v1 3/4] net: cadence_gem: Fix top comment, Peter Crosthwaite, 2014/05/07
- [Qemu-devel] [PATCH net v1 4/4] net: cadence_gem: Comment spelling sweep, Peter Crosthwaite, 2014/05/07
- Re: [Qemu-devel] [PATCH net v1 0/4] Cadence GEM patches, Peter Crosthwaite, 2014/05/14