[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/33] qcow2: Fix memory leak in COW error path
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 03/33] qcow2: Fix memory leak in COW error path |
Date: |
Fri, 23 May 2014 17:41:35 +0200 |
From: Kevin Wolf <address@hidden>
This triggers if bs->drv becomes NULL in a concurrent request. This is
currently only the case when corruption prevention kicks in (i.e. at
most once per image, and after that it produces I/O errors).
Signed-off-by: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/qcow2-cluster.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 76d2bcf..4208dc0 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -379,7 +379,8 @@ static int coroutine_fn copy_sectors(BlockDriverState *bs,
BLKDBG_EVENT(bs->file, BLKDBG_COW_READ);
if (!bs->drv) {
- return -ENOMEDIUM;
+ ret = -ENOMEDIUM;
+ goto out;
}
/* Call .bdrv_co_readv() directly instead of using the public block-layer
--
1.9.0
- [Qemu-devel] [PULL 00/33] Block patches, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 01/33] qemu-iotests: Handle cache mode option in 091, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 02/33] QemuOpt: add unit tests, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 03/33] qcow2: Fix memory leak in COW error path,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 04/33] aio: Fix use-after-free in cancellation path, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 06/33] block: Add BlockOpType enum, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 07/33] block: Introduce op_blockers to BlockDriverState, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 05/33] iotests: Use _img_info in test 089, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 09/33] block: Move op_blocker check from block_job_create to its caller, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 08/33] block: Replace in_use with operation blocker, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 10/33] block: Add bdrv_set_backing_hd(), Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 11/33] block: Use bdrv_set_backing_hd everywhere, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 12/33] block: Add backing_blocker in BlockDriverState, Stefan Hajnoczi, 2014/05/23
- [Qemu-devel] [PULL 13/33] block: Drop redundant bdrv_refresh_limits, Stefan Hajnoczi, 2014/05/23