[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/19] block: Purge qerror_report()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/19] block: Purge qerror_report() |
Date: |
Fri, 23 May 2014 17:40:01 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, May 16, 2014 at 11:00:07AM +0200, Markus Armbruster wrote:
> qerror_report() is a transitional interface to help with converting
> existing HMP commands to QMP. It should not be used elsewhere. This
> series purges it from the block subsystem.
>
> It is based on Fam's "[PATCH v19 00/16] Drop in_use from
> BlockDriverState and enable point-in-time snapshot exporting over
> NBD".
>
> v2:
> * Trivial rebase
> * Fix error propagation in PATCH 04 [Eric]
> * More tasteful line breaks in PATCH 04
> * Indentation cleanup in PATCH 10 [Eric]
> * Don't break sd_prealloc() in PATCH 14 [Eric]
> * Fix error propagation in PATCH 17
> * New PATCH 18 to fix silent failures
>
> Markus Armbruster (19):
> blockdev: Don't use qerror_report_err() in drive_init()
> blockdev: Don't use qerror_report() in do_drive_del()
> qemu-nbd: Don't use qerror_report()
> block/rbd: Propagate errors to open and create methods
> block/ssh: Drop superfluous libssh2_session_last_errno() calls
> block/ssh: Propagate errors through check_host_key()
> block/ssh: Propagate errors through authenticate()
> block/ssh: Propagate errors through connect_to_ssh()
> block/ssh: Propagate errors to open and create methods
> block/vvfat: Propagate errors through enable_write_target()
> block/vvfat: Propagate errors through init_directories()
> block/sheepdog: Propagate errors through connect_to_sdog()
> block/sheepdog: Propagate errors through get_sheep_fd()
> block/sheepdog: Propagate errors through sd_prealloc()
> block/sheepdog: Propagate errors through do_sd_create()
> block/sheepdog: Propagate errors through find_vdi_name()
> block/sheepdog: Propagate errors to open and create methods
> block/sheepdog: Fix silent sd_open(), sd_create() failures
> block/sheepdog: Don't use qerror_report()
>
> block/rbd.c | 71 ++++++++++++++------------
> block/sheepdog.c | 149 ++++++++++++++++++++++++++++++++++--------------------
> block/ssh.c | 151
> +++++++++++++++++++++++++++++++++----------------------
> block/vvfat.c | 34 ++++++-------
> blockdev.c | 7 ++-
> qemu-nbd.c | 6 +--
> 6 files changed, 246 insertions(+), 172 deletions(-)
>
> --
> 1.8.1.4
>
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
- Re: [Qemu-devel] [PATCH v2 18/19] block/sheepdog: Fix silent sd_open(), sd_create() failures, (continued)
- [Qemu-devel] [PATCH v2 13/19] block/sheepdog: Propagate errors through get_sheep_fd(), Markus Armbruster, 2014/05/16
- [Qemu-devel] [PATCH v2 16/19] block/sheepdog: Propagate errors through find_vdi_name(), Markus Armbruster, 2014/05/16
- [Qemu-devel] [PATCH v2 11/19] block/vvfat: Propagate errors through init_directories(), Markus Armbruster, 2014/05/16
- [Qemu-devel] [PATCH v2 06/19] block/ssh: Propagate errors through check_host_key(), Markus Armbruster, 2014/05/16
- [Qemu-devel] [PATCH v2 01/19] blockdev: Don't use qerror_report_err() in drive_init(), Markus Armbruster, 2014/05/16
- [Qemu-devel] [PATCH v2 02/19] blockdev: Don't use qerror_report() in do_drive_del(), Markus Armbruster, 2014/05/16
- [Qemu-devel] [PATCH v2 03/19] qemu-nbd: Don't use qerror_report(), Markus Armbruster, 2014/05/16
- [Qemu-devel] [PATCH v2 10/19] block/vvfat: Propagate errors through enable_write_target(), Markus Armbruster, 2014/05/16
- [Qemu-devel] [PATCH v2 05/19] block/ssh: Drop superfluous libssh2_session_last_errno() calls, Markus Armbruster, 2014/05/16
- Re: [Qemu-devel] [PATCH v2 00/19] block: Purge qerror_report(),
Stefan Hajnoczi <=