[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/20] block: Handle failure for potentially lar
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 02/20] block: Handle failure for potentially large allocations |
|
Date: |
Thu, 22 May 2014 17:50:53 +0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, May 21, 2014 at 06:28:00PM +0200, Kevin Wolf wrote:
> @@ -2270,7 +2270,10 @@ int bdrv_commit(BlockDriverState *bs)
> }
>
> total_sectors = length >> BDRV_SECTOR_BITS;
> - buf = g_malloc(COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE);
> +
> + /* qemu_try_blockalign() for bs will choose an alignment that works for
> + * bs->backing_hd as well, so no need to compare the alignment manually.
> */
> + buf = qemu_try_blockalign(bs, COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE);
Missing ENOMEM error handling?
- [Qemu-devel] [PATCH 00/20] block: Handle failure for potentially large allocations, Kevin Wolf, 2014/05/21
- [Qemu-devel] [PATCH 01/20] block: Introduce qemu_try_blockalign(), Kevin Wolf, 2014/05/21
- [Qemu-devel] [PATCH 03/20] bochs: Handle failure for potentially large allocations, Kevin Wolf, 2014/05/21
- [Qemu-devel] [PATCH 04/20] cloop: Handle failure for potentially large allocations, Kevin Wolf, 2014/05/21
- [Qemu-devel] [PATCH 02/20] block: Handle failure for potentially large allocations, Kevin Wolf, 2014/05/21
- Re: [Qemu-devel] [PATCH 02/20] block: Handle failure for potentially large allocations,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 05/20] curl: Handle failure for potentially large allocations, Kevin Wolf, 2014/05/21
- [Qemu-devel] [PATCH 06/20] dmg: Handle failure for potentially large allocations, Kevin Wolf, 2014/05/21
- [Qemu-devel] [PATCH 07/20] iscsi: Handle failure for potentially large allocations, Kevin Wolf, 2014/05/21
- [Qemu-devel] [PATCH 09/20] parallels: Handle failure for potentially large allocations, Kevin Wolf, 2014/05/21