[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/7] libcacard: Plug memory leaks around vreader_get
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 2/7] libcacard: Plug memory leaks around vreader_get_reader_list() |
Date: |
Thu, 22 May 2014 16:57:17 +0200 |
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
---
libcacard/vcard_emul_nss.c | 4 ++++
libcacard/vscclient.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index e2b196d..692534c 100644
--- a/libcacard/vcard_emul_nss.c
+++ b/libcacard/vcard_emul_nss.c
@@ -433,11 +433,13 @@ vcard_emul_find_vreader_from_slot(PK11SlotInfo *slot)
VReader *reader = vreader_list_get_reader(current_entry);
VReaderEmul *reader_emul = vreader_get_private(reader);
if (reader_emul->slot == slot) {
+ vreader_list_delete(reader_list);
return reader;
}
vreader_free(reader);
}
+ vreader_list_delete(reader_list);
return NULL;
}
@@ -1059,6 +1061,8 @@ vcard_emul_replay_insertion_events(void)
next_entry = vreader_list_get_next(current_entry);
vreader_queue_card_event(vreader);
}
+
+ vreader_list_delete(list);
}
/*
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index 29f4958..f2a753a 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -570,6 +570,7 @@ do_command(GIOChannel *source,
"CARD_PRESENT" : " ",
vreader_get_name(reader));
}
+ vreader_list_delete(list);
} else if (*string != 0) {
printf("valid commands:\n");
printf("insert [reader_id]\n");
--
1.9.0
- [Qemu-devel] [PATCH 0/7] libcacard: A few simple fixes and cleanups, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 4/7] libcacard/vreader: Tighten assertion to clarify intent, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 5/7] libcacard: Convert two leftover realloc() to GLib, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 3/7] libcacard/vreader: Drop broken recovery from failed assertion, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 2/7] libcacard: Plug memory leaks around vreader_get_reader_list(),
Markus Armbruster <=
- [Qemu-devel] [PATCH 1/7] libcacard/vscclient: Bury some dead code, Markus Armbruster, 2014/05/22
- Re: [Qemu-devel] [PATCH 0/7] libcacard: A few simple fixes and cleanups, Alon Levy, 2014/05/22