qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()
Date: Thu, 22 May 2014 13:16:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 22/05/2014 12:23, Stefan Hajnoczi ha scritto:
I had an intermediate version of this patch with a flag so you could
tell object_property_add_alias() whether or not to ref the target
object.  But in the end it seems like overengineering since the
refcount case is rare or non-existent.  The refcount is a convenience
feature just for the case where you want to alias to a random object
that you don't otherwise hold a refcount on (I couldn't think of an
example).

Do you see what I mean?

Yes, and it makes sense.  Perhaps add a comment for v2.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]