[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/22] target-arm: A64: Introduce aarch64_ban
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v3 09/22] target-arm: A64: Introduce aarch64_banked_spsr_index() |
Date: |
Wed, 21 May 2014 23:50:25 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, May 21, 2014 at 08:01:54PM +0100, Peter Maydell wrote:
> On 19 May 2014 10:22, Edgar E. Iglesias <address@hidden> wrote:
> > From: "Edgar E. Iglesias" <address@hidden>
> >
> > Add aarch64_banked_spsr_index(), used to map an Exception Level
> > to an index in the banked_spsr array.
> >
> > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
> > index f120b02..c05a839 100644
> > --- a/target-arm/op_helper.c
> > +++ b/target-arm/op_helper.c
> > @@ -386,7 +386,8 @@ void HELPER(msr_i_pstate)(CPUARMState *env, uint32_t
> > op, uint32_t imm)
> >
> > void HELPER(exception_return)(CPUARMState *env)
> > {
> > - uint32_t spsr = env->banked_spsr[0];
> > + unsigned int spsr_idx = is_a64(env) ? aarch64_banked_spsr_index(1) : 0;
>
> This is unnecessary -- if we get here we must have is_a64(env) true,
> because this is the helper for an A64 instruction.
Yep, got confused while your previous comments. Fixed
>
> > + uint32_t spsr = env->banked_spsr[spsr_idx];
> > int new_el, i;
> >
> > if (env->pstate & PSTATE_SP) {
>
> thanks
> -- PMM
- [Qemu-devel] [PATCH v3 01/22] target-arm: Make elr_el1 an array, (continued)
- [Qemu-devel] [PATCH v3 01/22] target-arm: Make elr_el1 an array, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 02/22] target-arm: Make esr_el1 an array, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 03/22] target-arm: c12_vbar -> vbar_el[], Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 04/22] target-arm: Add arm_el_to_mmu_idx(), Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 05/22] target-arm: Move get_mem_index to translate.h, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 06/22] target-arm: A64: Add SP entries for EL2 and 3, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 07/22] target-arm: A64: Add ELR entries for EL2 and 3, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 08/22] target-arm: Add SPSR entries for EL2/HYP and EL3/MON, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 09/22] target-arm: A64: Introduce aarch64_banked_spsr_index(), Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 10/22] target-arm: Add a feature flag for EL2, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 11/22] target-arm: Add a feature flag for EL3, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 12/22] target-arm: Register EL2 versions of ELR and SPSR, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 13/22] target-arm: Register EL3 versions of ELR and SPSR, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 14/22] target-arm: A64: Forbid ERET to increase the EL, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 15/22] target-arm: A64: Forbid ERET to unimplemented ELs, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs, Edgar E. Iglesias, 2014/05/19