[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v20 03/15] block: Replace in_use with operation
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v20 03/15] block: Replace in_use with operation blocker |
Date: |
Wed, 21 May 2014 14:46:57 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, May 20, 2014 at 02:04:28PM +0800, Fam Zheng wrote:
> This drops BlockDriverState.in_use with op_blockers:
>
> - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1).
>
> - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0).
>
> - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs).
>
> The specific types are used, e.g. in place of starting block backup,
> bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_BACKUP, ...).
>
> There is one exception in block_job_create, where
> bdrv_op_blocker_is_empty() is used, because we don't know the operation
> type here. This doesn't matter because in a few commits away we will drop
> the check and move it to callers that _do_ know the type.
>
> - Check bdrv_op_blocker_is_empty() in place of assert(!bs->in_use).
>
> Note: there is only bdrv_op_block_all and bdrv_op_unblock_all callers at
> this moment. So although the checks are specific to op types, this
> changes can still be seen as identical logic with previously with
> in_use. The difference is error message are improved because of blocker
> error info.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: Jeff Cody <address@hidden>
> ---
> block-migration.c | 7 +++++--
> block.c | 24 +++++++-----------------
> blockdev.c | 19 +++++++++----------
> blockjob.c | 14 +++++++++-----
> hw/block/dataplane/virtio-blk.c | 18 ++++++++++++------
> include/block/block.h | 2 --
> include/block/block_int.h | 1 -
> include/block/blockjob.h | 3 +++
> 8 files changed, 45 insertions(+), 43 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
- [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD, Fam Zheng, 2014/05/20
- [Qemu-devel] [PATCH v20 01/15] block: Add BlockOpType enum, Fam Zheng, 2014/05/20
- [Qemu-devel] [PATCH v20 02/15] block: Introduce op_blockers to BlockDriverState, Fam Zheng, 2014/05/20
- [Qemu-devel] [PATCH v20 03/15] block: Replace in_use with operation blocker, Fam Zheng, 2014/05/20
- Re: [Qemu-devel] [PATCH v20 03/15] block: Replace in_use with operation blocker,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Fam Zheng, 2014/05/20
- Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Jeff Cody, 2014/05/20
- Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Fam Zheng, 2014/05/20
- Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Jeff Cody, 2014/05/21
- Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Fam Zheng, 2014/05/21
- Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Stefan Hajnoczi, 2014/05/21
- Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Jeff Cody, 2014/05/21
- Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Jeff Cody, 2014/05/21
Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Stefan Hajnoczi, 2014/05/21
[Qemu-devel] [PATCH v20 05/15] block: Add bdrv_set_backing_hd(), Fam Zheng, 2014/05/20