[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] console: Abort on property access errors
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] console: Abort on property access errors |
|
Date: |
Wed, 21 May 2014 11:55:49 +0200 |
On Do, 2014-04-24 at 18:15 +0400, Kirill Batuzov wrote:
> All defined properties of QemuConsole are mandatory and no access to them
> should fail. Nevertheless not checking returned errors is bad because in case
> of unexpected failure it will hide the bug and cause a memory leak.
>
> Abort in case of unexpected property access errors. This change exposed a bug
> where an attempt was made to write to a read-only property "head".
>
> Set "head" property's value at creation time and do not attempt to change it
> later. This fixes the bug mentioned above.
Picked into my console branch.
thanks,
Gerd