Re: [Qemu-devel] [v2][PATCH 8/8] xen, gfx passthrough: add opregion mapping

[Chen, Tiejun]

> -----Original Message-----
> From: Stefano Stabellini [mailto:address@hidden
> Sent: Tuesday, May 20, 2014 6:51 PM
> To: Chen, Tiejun
> Cc: Stefano Stabellini; address@hidden; address@hidden;
> address@hidden; address@hidden;
> address@hidden; address@hidden;
> address@hidden; Kay, Allen M; Zhang, Yang Z
> Subject: RE: [v2][PATCH 8/8] xen, gfx passthrough: add opregion mapping
> 

[snip]

> > > >
> > > > +        if (xen_pt_emu_reg_grps[i].grp_id == PCI_INTEL_OPREGION) {
> > > > +            reg_grp_offset = PCI_INTEL_OPREGION;
> > > > +        }
> > > > +
> >
> > But for this pass through scenario, we have to set 0xfc manually since we
> need to trap 0xfc completely in that comment:
> >
> > +    /*
> > +    ** By default we will trap up to 0x40 in the cfg space.
> > +    ** If an intel device is pass through we need to trap 0xfc,
> > +    ** therefore the size should be 0xff.
> > +    */
> 
> OK. Can you please keep this comment in your patch? Thanks!

Sure.

Thanks
Tiejun