[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/5] char: Clean up fragile use of error_is_s
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/5] char: Clean up fragile use of error_is_set() |
Date: |
Mon, 19 May 2014 11:15:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/19/2014 10:57 AM, Markus Armbruster wrote:
> Using error_is_set(ERRP) to find out whether a function failed is
> either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
> may be null, because errors go undetected when it is. It's fragile
> when proving ERRP non-null involves a non-local argument. Else, it's
> unnecessarily opaque (see commit 84d18f0).
>
> The error_is_set(errp) in qemu_chr_new_from_opts() is merely fragile,
> because the callers never pass a null errp argument.
>
> Make the code more robust and more obviously correct: receive the
> error in a local variable, then propagate it through the parameter.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-char.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/5] char: Purge error_is_set(), Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error_is_set(errp), Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusual error handling, Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 4/5] qemu-socket: Clean up inet_connect_opts(), Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 5/5] error: error_is_set() is finally unused; remove, Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 2/5] char: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/19
- Re: [Qemu-devel] [PATCH v2 2/5] char: Clean up fragile use of error_is_set(),
Eric Blake <=