[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum |
|
Date: |
Mon, 19 May 2014 18:15:40 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 05/11/2014 07:35 PM, Fam Zheng wrote:
>> This adds the enum of all the operations that can be taken on a block
>> device.
>>
>> Signed-off-by: Fam Zheng <address@hidden>
>> Reviewed-by: Benoit Canet <address@hidden>
>> Reviewed-by: Jeff Cody <address@hidden>
>> ---
>> include/block/block.h | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>
> Is it worth making this a formal QAPI enum, documented in the .json
> file? If we ever add qapi introspection, it might be nice to know when
> new block op types are added as part of the formal qapi definition.
Moving it into the schema when QAPI needs it shouldn't be hard.
[Qemu-devel] [PATCH v19 05/16] block: Move op_blocker check from block_job_create to its caller, Fam Zheng, 2014/05/11
[Qemu-devel] [PATCH v19 04/16] block: Replace in_use with operation blocker, Fam Zheng, 2014/05/11