Re: [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum

[Markus Armbruster]

Fam Zheng <address@hidden> writes:

> This adds the enum of all the operations that can be taken on a block
> device.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: Benoit Canet <address@hidden>
> Reviewed-by: Jeff Cody <address@hidden>
> ---
>  include/block/block.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/include/block/block.h b/include/block/block.h
> index 467fb2b..ac3a69b 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -155,6 +155,25 @@ typedef struct BDRVReopenState {
>      void *opaque;
>  } BDRVReopenState;
>  
> +/*
> + * Block operation types
> + */
> +typedef enum BlockOpType {
> +    BLOCK_OP_TYPE_BACKUP_SOURCE,
> +    BLOCK_OP_TYPE_BACKUP_TARGET,
> +    BLOCK_OP_TYPE_CHANGE,
> +    BLOCK_OP_TYPE_COMMIT,
> +    BLOCK_OP_TYPE_DATAPLANE,
> +    BLOCK_OP_TYPE_DRIVE_DEL,
> +    BLOCK_OP_TYPE_EJECT,
> +    BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT,
> +    BLOCK_OP_TYPE_INTERNAL_SNAPSHOT,
> +    BLOCK_OP_TYPE_INTERNAL_SNAPSHOT_DELETE,
> +    BLOCK_OP_TYPE_MIRROR,
> +    BLOCK_OP_TYPE_RESIZE,
> +    BLOCK_OP_TYPE_STREAM,
> +    BLOCK_OP_TYPE_MAX,
> +} BlockOpType;
>  
>  void bdrv_iostatus_enable(BlockDriverState *bs);
>  void bdrv_iostatus_reset(BlockDriverState *bs);

Observation, not objection: BLOCK_OP_TYPE_COMMIT,
BLOCK_OP_TYPE_INTERNAL_SNAPSHOT and
BLOCK_OP_TYPE_INTERNAL_SNAPSHOT_DELETE are not used in this series.