[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] doc: add "setup" to list of migration states
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] doc: add "setup" to list of migration states |
Date: |
Fri, 16 May 2014 09:04:28 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/16/2014 08:40 AM, address@hidden wrote:
> From: Peter Feiner <address@hidden>
>
> On a slow VM (e.g., nested), you see the "setup" state when you query the
> migration status.
>
> Signed-off-by: Peter Feiner <address@hidden>
> ---
> qapi-schema.json | 2 +-
> qmp-commands.hx | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 36cb964..f4ffede 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -691,7 +691,7 @@
> # Information about current migration process.
> #
> # @status: #optional string describing the current migration status.
> -# As of 0.14.0 this can be 'active', 'completed', 'failed' or
> +# As of 0.14.0 this can be 'setup', 'active', 'completed', 'failed'
> or
You know, it would be even nicer to convert from an open-coded 'str' to
a finite enum of valid strings; it would be self-documenting, and make
it that much easier to guarantee the code doesn't add new states without
documenting when they were added.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature