[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes |
Date: |
Thu, 15 May 2014 22:03:59 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
The Thursday 15 May 2014 à 13:39:02 (-0600), Eric Blake wrote :
> On 05/15/2014 01:13 PM, Luiz Capitulino wrote:
> > On Wed, 14 May 2014 16:07:49 +0200
> > Benoît Canet <address@hidden> wrote:
> >
> >> The purpose of this change is to help create a json file containing
> >> common definitions; each bit of generated C code must be emitted
> >> only one time.
> >>
> >> A second history global to all QAPISchema instances has been added
> >> to detect when a file is included more than one time and skip these
> >> includes.
> >> It does not act as a stack and the changes made to it by the
> >> __init__ function are propagated back to the caller so it's really
> >> a global state.
> >
> > Shouldn't this behavior be noted somewhere? Eg. in writing-qmp-commands.txt
> > or qapi-code-gen.txt?
>
> dosc/qapi-code-gen.txt already covers the {'include':'file'} syntax, so
> yes, that should be updated to mention that multiple includes of the
> same file are now safe.
ok, I will do this.
Best regards
Benoît
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>