[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for migratab
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for migratability status |
Date: |
Thu, 15 May 2014 11:15:26 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, May 15, 2014 at 04:05:44PM +0200, Juan Quintela wrote:
> Andreas Färber <address@hidden> wrote:
> > Am 15.05.2014 14:14, schrieb Juan Quintela:
> >> Eduardo Habkost <address@hidden> wrote:
> >>> From: Marcelo Tosatti <address@hidden>
> >>>
> >>> Check vmsd for unmigratable field, allowing migratibility status
> >>> to be modified after vmstate_register.
> >>>
> >>> Cc: Juan Quintela <address@hidden>
> >>> Signed-off-by: Marcelo Tosatti <address@hidden>
> >>> Reviewed-by: Eduardo Habkost <address@hidden>
> >>> Signed-off-by: Eduardo Habkost <address@hidden>
> >>
> >> I agree with the patch spirt, but what happens if we want to disable
> >> migration in a device that has no VMSD?
> >
> > As the patch shows, no non-VMSD device setting no_migrate exists today.
> > Do you expect any to appear? I'm rather seeing more and more devices
> > getting converted to VMSD.
>
> I want people to notice that. As said, I hope that everything new uses
> VMSD.
Note that devices that have no VMSD couldn't set no_migrate before this
patch, anyway (the only way to set no_migrate was using a VMSD). The
change is not visible outside savevm.c.
If we want to disable migration in a device that has no VMSD, we will
need a savevm API change. If that ever happens, re-adding the field to
support the API change would be trivial.
--
Eduardo
- [Qemu-devel] [PATCH RESEND v4 10/18] target-i386: Loop-based copying and setting/unsetting of feature words, (continued)
- [Qemu-devel] [PATCH RESEND v4 10/18] target-i386: Loop-based copying and setting/unsetting of feature words, Eduardo Habkost, 2014/05/14
- [Qemu-devel] [PATCH RESEND v4 11/18] target-i386: Loop-based feature word filtering in TCG mode, Eduardo Habkost, 2014/05/14
- [Qemu-devel] [PATCH RESEND v4 12/18] target-i386: Support check/enforce flags in TCG mode, too, Eduardo Habkost, 2014/05/14
- [Qemu-devel] [PATCH RESEND v4 13/18] target-i386: Support "-cpu host" in TCG mode, Eduardo Habkost, 2014/05/14
- [Qemu-devel] [PATCH RESEND v4 15/18] target-i386: Set migratable=yes by default, Eduardo Habkost, 2014/05/14
- [Qemu-devel] [PATCH RESEND v4 14/18] target-i386: Add "migratable" property to "host" CPU model, Eduardo Habkost, 2014/05/14
- [Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for migratability status, Eduardo Habkost, 2014/05/14
[Qemu-devel] [PATCH RESEND v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed, Eduardo Habkost, 2014/05/14
[Qemu-devel] [PATCH RESEND v4 18/18] target-i386: support "invariant tsc" flag, Eduardo Habkost, 2014/05/14
Re: [Qemu-devel] [PATCH RESEND v4 00/18] target-i386: CPU feature flag queue, Andreas Färber, 2014/05/14