[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/18] block/vvfat: Propagate errors through ini
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 11/18] block/vvfat: Propagate errors through init_directories() |
Date: |
Wed, 14 May 2014 11:45:28 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/13/2014 10:02 AM, Markus Armbruster wrote:
> Completes the conversion of the open method to Error started in commit
> 015a103.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/vvfat.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> @@ -892,8 +893,8 @@ static int init_directories(BDRVVVFATState* s,
> if (mapping->mode & MODE_DIRECTORY) {
> mapping->begin = cluster;
> if(read_directory(s, i)) {
> - fprintf(stderr, "Could not read directory %s\n",
> - mapping->path);
> + error_setg(errp, "Could not read directory %s",
> + mapping->path);
I see you fixed some TABs in the process; is it worth widening the fix
to the rest of the 'if' statement? I don't care either way, as long as
checkpatch.pl didn't call you out (the new code is correct, even though
the existing code was not).
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls, (continued)
- [Qemu-devel] [PATCH 10/18] block/vvfat: Propagate errors through enable_write_target(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 07/18] block/ssh: Propagate errors through authenticate(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 06/18] block/ssh: Propagate errors through check_host_key(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 11/18] block/vvfat: Propagate errors through init_directories(), Markus Armbruster, 2014/05/13
- Re: [Qemu-devel] [PATCH 11/18] block/vvfat: Propagate errors through init_directories(),
Eric Blake <=
- [Qemu-devel] [PATCH 13/18] block/sheepdog: Propagate errors through get_sheep_fd(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 09/18] block/ssh: Propagate errors to open and create methods, Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 18/18] block/sheepdog: Don't use qerror_report(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 15/18] block/sheepdog: Propagate errors through do_sd_create(), Markus Armbruster, 2014/05/13