[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help fun
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function |
|
Date: |
Tue, 13 May 2014 15:48:26 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/13/2014 03:11 PM, Mike Day wrote:
Subject line could have used a [PATCHv2] designation to make it obvious
this is a fixed version. But that doesn't affect what goes into git.
> g_sequence_lookup is not supported by glib < 2.28. The usage
> of g_sequence_lookup is not essential in this context (it's a
> safeguard against duplicate values in the help message).
> Removing the call enables the build on all platforms and
> does not change the operation of the help function.
>
> Signed-off-by: Mike Day <address@hidden>
> ---
> qemu-img.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature