Re: [Qemu-devel] [PATCH v2 02/16] s390: Convert conditional compilation of debug printfs to regular ifs

[Eric Blake]

On 05/13/2014 01:02 AM, Marc Marí wrote:
> Modify debug macros to have the same format through the codebase and use 
> regular
> ifs instead of ifdef.
> 
> As the debug printf is always put in code, some casting had to be added to 
> avoid
> warnings treated as errors at compile time.

Same comments as in 1/16: make the commit message accurate, wrap long
lines, and see if you can avoid using gcc extensions.

> 
> Signed-off-by: Marc Marí <address@hidden>
> ---
>  hw/s390x/s390-virtio-bus.c |    8 ++++----
>  hw/s390x/s390-virtio.c     |    8 ++++----
>  target-s390x/helper.c      |   22 ++++++++++++++--------
>  target-s390x/kvm.c         |    8 ++++----
>  4 files changed, 26 insertions(+), 20 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature