[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h |
Date: |
Tue, 13 May 2014 06:44:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/13/2014 02:34 AM, Alex Bennée wrote:
> I'm having trouble figuring out what the sizemask stuff was trying to
> achieve and if it's required/covered after the change. Is the final
> helper now the one defined as?
>
> DEF(div_i32, 1, 2, 0, IMPL(TCG_TARGET_HAS_div_i32))
>
> it's hard to follow the parameters of this compared to the target
> helpers where the the argument sizes are a lot more explicit.
The sizemask stuff is about encoding the argument types of the function.
What you've quoted above is not the helper, but the TCG opcode.
The helper is defined as
DEF_HELPER_FLAGS_2(div_i32, TCG_CALL_NO_RWG_SE, s32, s32, s32)
in the previous patch.
r~
- [Qemu-devel] [PATCH 02/10] tcg: Invert the inclusion of helper.h, (continued)
- [Qemu-devel] [PATCH 02/10] tcg: Invert the inclusion of helper.h, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 03/10] tcg: Push tcg-runtime routines into exec/helper-*, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 05/10] tcg: Inline tcg_gen_helperN, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 06/10] tcg: Move side effects out of dh_sizemask, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 08/10] tcg: Save flags and computed sizemask in TCGHelperInfo, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 07/10] tcg: Register the helper info struct rather than the name, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 09/10] tcg: Remove sizemask and flags arguments to tcg_gen_callN, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 10/10] tcg: Move size effects out of dh_arg, Richard Henderson, 2014/05/12