[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-img fails to delete last snapshot
From: |
Mike Day |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-img fails to delete last snapshot |
Date: |
Mon, 12 May 2014 14:31:05 -0400 |
On Mon, May 12, 2014 at 12:39 PM, Eric Blake <address@hidden> wrote:
> This information is actually quite useful in understanding the patch,
> and I would have included it prior to the --- for inclusion in git,
> rather than in the reviewer-only commentary that gets stripped during
> 'git am'.
>
>>
>> block/qcow2-snapshot.c | 25 +++++++++++++++----------
>> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> I'd suggest posting a v2 with a better commit message; but the code
> itself seems fine, so you can add:
>
> Reviewed-by: Eric Blake <address@hidden>
Got it, thanks!
Mike